Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: deno-chromium #4481

Closed
4 of 6 tasks
frank-dspeed opened this issue Mar 24, 2020 · 6 comments
Closed
4 of 6 tasks

WIP: deno-chromium #4481

frank-dspeed opened this issue Mar 24, 2020 · 6 comments
Labels

Comments

@frank-dspeed
Copy link

frank-dspeed commented Mar 24, 2020

To Replace NW.JS and Electron I should extend deno with simple rust-bindings-cfe via deno-plugin-chromium or if I should investigate into somehow directly modify deno to use the same v8 instance of the cfe NW.JS Demonstrates that well for nodejs

Updates will create Optimized build that will share v8 with a chromium build

@frank-dspeed frank-dspeed changed the title What would be the better Path? chromium integration: What would be the better Path? Mar 24, 2020
@ry
Copy link
Member

ry commented Mar 25, 2020

It would be very cool to get a chromium build that shared V8. You should look into how we setup the build in rusty_v8 (our Rust bindings to V8)
https://github.com/denoland/rusty_v8/blob/v0.3.8/.gn
https://github.com/denoland/rusty_v8/blob/v0.3.8/BUILD.gn

Also have a look at https://github.com/eliassjogreen/deno_webview

@frank-dspeed
Copy link
Author

@ry can you line out all findings that you had as you tryed to use a prebuild v8 ? i remember you writed some where something about why we even need to compile v8 our self.

@frank-dspeed
Copy link
Author

first experiment that i will try is to build cfe with chromium master and our gn settings for v8 and simply look what we get :)

@frank-dspeed
Copy link
Author

I found out that this is a bigger project I found an eq one for nodejs https://github.com/nwjs I will go for https://github.com/dwjs and look into the implementation of them since they got the same shared heap concept that I have in mind

@frank-dspeed frank-dspeed changed the title chromium integration: What would be the better Path? deno-chromium Apr 6, 2020
@frank-dspeed frank-dspeed changed the title deno-chromium WIP: deno-chromium Apr 6, 2020
@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2021
@frank-dspeed
Copy link
Author

It turns out that it will bring not the expected performance benefits the project is abondonend with the conclusion that it is not worth the effort as it will not reduce the serialisation and context switching reduction as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants