Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a deno example using Chrome #95

Open
jlandure opened this issue May 26, 2020 · 4 comments
Open

Get a deno example using Chrome #95

jlandure opened this issue May 26, 2020 · 4 comments
Labels
good first issue Hacktoberfest Ready for new contributors to work on! help wanted

Comments

@jlandure
Copy link
Owner

Context

It could be fun to get a deno example using Chrome using the with-deno tag.
See the with-deno folder

Related to #89

@aceol
Copy link

aceol commented May 28, 2020

Would be glad to do that! I'll give a try ASAP

@jlandure
Copy link
Owner Author

Hi @aceol 👋

Thanks for your motivation! 👍
For your information, I've discussed with @hgwood and said:

node and deno are incompatible
You can't run a node lib in deno except if there is dependency to nodejs.

And in the deno page

Deno is not compatible, in general, with Node (NPM) packages. There is a nascent compatibility layer being built at https://deno.land/std/node/ but it is far from complete. ... Over time, we expect Deno to be able to run more and more Node programs out-of-the-box

@aceol
Copy link

aceol commented Jun 13, 2020

Hi @jlandure sorry for the delay.
What exactly do you mean by a deno example using Chrome, any specific idea?

I can see it's not working with puppeteer. I had to update the Dockerfile commenting
#RUN git clone https://github.com/puppeteer/puppeteer/blob/master/src/ puppeteer
I guess it's a known issue but is that ok to be on the master branch?

@jlandure
Copy link
Owner Author

Hi @aceol 👋

💬 I think about running something with deno using a Chromium (in Docker)
See : denoland/deno#1120 or denoland/deno#4481 (and this demo)

👌 Yes Puppeteer will not work because of its node dependencies. See my comment #95 (comment)

💡 Do you have any another idea in mind?

@jlandure jlandure added the Hacktoberfest Ready for new contributors to work on! label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Hacktoberfest Ready for new contributors to work on! help wanted
Projects
None yet
Development

No branches or pull requests

2 participants