Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-check doesn't support some features #7080

Closed
kitsonk opened this issue Aug 17, 2020 · 1 comment · Fixed by #7289
Closed

no-check doesn't support some features #7080

kitsonk opened this issue Aug 17, 2020 · 1 comment · Fixed by #7289
Assignees

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 17, 2020

The current implementation of --no-check does not support some features which are supportable without the flag. The related TypeScript compiler options are:

  • emitDecoratorMetadata - If experimentalDecorators is true and this is true then meta data is emitted.
  • experimentalDecorators - Isn't set to true by default, but can be set using a tsconfig.json.
  • jsx - By default we use "react" setting. Current behaviour is effectively the default of "preserve".
  • jsxFactory - This feature is supported using a tsconfig.json.
  • jsxFragmentFactory - This feature is supported using a tsconfig.json.

Currently we support reactNamespace but it should be ignored. It is deprecated and redundant with the jsxFactory and jsxFragmentFactory options.

cc/ @bartlomieju

@bartlomieju bartlomieju self-assigned this Aug 17, 2020
@bartlomieju
Copy link
Member

bartlomieju commented Aug 22, 2020

@kitsonk I'm gonna backport your solution from #6894 into #7161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants