fix: support missing features in --no-check #7289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
fix_no_check
branch
from
3a14356
to
42d2c5e
Compare
bartlomieju
changed the title
|
@kitsonk PTAL |
|
Waiting for Kitson’s review. Are there any additional tests from Kitson’s branch relating to these no-check fixes? |
kitsonk
reviewed
Sep 1, 2020
There was a problem hiding this comment.
LGTM outside as @ry mentioned, we should have either integration tests for the new features or unit tests which I had in the branch: https://github.com/kitsonk/deno/blob/deno_compiler/compiler/ast.rs#L796-L846
Thanks, I'll use those 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7080