Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blob URL support #10045

Merged
merged 3 commits into from
Apr 7, 2021
Merged

feat: blob URL support #10045

merged 3 commits into from
Apr 7, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Apr 6, 2021

This commit adds blob URL support. Blob URLs are stored in a process
global storage, that can be accessed from all workers, and the module
loader. Blob URLs can be created using URL.createObjectURL and revoked
using URL.revokeObjectURL.

This commit does not add support for fetching blob URLs. This will be
added in a follow up commit.

This PR depends on #10042.

Closes #9210
Closes #2726

This commit adds blob URL support. Blob URLs are stored in a process
global storage, that can be accessed from all workers, and the module
loader. Blob URLs can be created using `URL.createObjectURL` and revoked
using `URL.revokeObjectURL`.

This commit does not add support for `fetch`ing blob URLs. This will be
added in a follow up commit.
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts...

Great news though!

cli/source_maps.rs Outdated Show resolved Hide resolved
cli/tsc.rs Outdated Show resolved Hide resolved
op_crates/file/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is going to be awesome.

@lucacasonato lucacasonato merged commit 966ce7d into denoland:main Apr 7, 2021
@lucacasonato lucacasonato deleted the blob_url branch April 7, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support blob/Object URLs for workers Support for data URLs and object URLs
2 participants