Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serde_v8): support #[serde(default)] #13300

Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(serde_v8): support #[serde(default)] #13300

merged 1 commit into from
Jan 7, 2022

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Jan 7, 2022 •
edited
Loading

Fixes #13185 but slightly degrades error quality

Also rewrote struct deserialization to use a SeqAccess instead of a MapAccess making it simpler

bartlomieju
bartlomieju approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronO AaronO merged commit 12423e1 into denoland:main Jan 7, 2022
@AaronO AaronO deleted the fix/serde-v8-default branch January 7, 2022 12:08
crowlKats pushed a commit that referenced this pull request Jan 12, 2022
@AaronO @crowlKats
fix(serde_v8): support #[serde(default)] (#13300)
f336cd1
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
@AaronO
fix(serde_v8): support #[serde(default)] (denoland#13300)
3a59a02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serde_v8 serde default support
2 participants
@AaronO @bartlomieju