-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/fetch): add Headers#getSetCookie #13542
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Now that the spec PR is about to land, this PR should be reopened. |
Hey, aside from web-platform-tests/wpt#31442, I also opened web-platform-tests/wpt#38437 with some extra tests to address some of the review feedback from the Webkit implementation. Note that the "Set-Cookie is a forbidden response header" test is about browser behavior and doesn't apply to Deno. |
21bd01c
to
4e7ebb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4e7ebb2
to
1a15511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be rebased and landed. Spec changes have gone through and I presume this would be a fairly important feature for eg. Node compat.
Tried to use this today, was missing in Deno |
For the record, this implementation is correct according to the spec as it is now. The only changes in the spec text since were editorial. There is one failing test in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Spec change: whatwg/fetch#1346
Tests: web-platform-tests/wpt#31442 (ran against this PR and they all pass)