Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Deno.umask (with no argument call) #13639

Closed
wants to merge 6 commits into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 10, 2022

This PR removes the no argument version of Deno.umask as suggested in #13632

closes #13632

@piscisaureus
Copy link
Member

Having a bit of cold feet about this now.
I didn't realize that the default umask isn't 0 but 0o022, unless you configure it otherwise.

@kt3k
Copy link
Member Author

kt3k commented Feb 11, 2022

@piscisaureus
How about only removing the query version of Deno.umask? (i.e. keep Deno.umask(newMask: number): number and remove Deno.umask(): number. That also solves the broken permission issue.

Researched a little bit on other languages. Python and Golang has only setting APIs. Ruby has both. Node.js used to have both, but deprecated querying version recently after a similar discussion to our case.

@kt3k kt3k changed the title chore: remove Deno.umask chore: remove Deno.umask (with no argument call) Feb 15, 2022
@piscisaureus piscisaureus self-requested a review February 16, 2022 20:06
@stale
Copy link

stale bot commented Apr 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2022
@kt3k
Copy link
Member Author

kt3k commented Apr 19, 2022

Let's track in the issue #13632

@kt3k kt3k closed this Apr 19, 2022
@kt3k kt3k deleted the remove-umask branch April 19, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Remove Deno.umask (with no argument call)
2 participants