-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade deno_std #2064
Upgrade deno_std #2064
Conversation
This is failing because the unit test summary is printed twice for some reason.
I assume this has something to do with the flag changes... Any idea @kt3k @bartlomieju ? |
@ry import "deps/https/deno.land/std/testing/main.ts"; to the following: import { runTests } from "deps/https/deno.land/std/testing/mod.ts";
runTests(); Then tests seem working normally (but I found another failure with (Is std/testing/main.ts intended as the general entrypoint of testing?) |
In // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
import { runTests } from "./mod.ts";
async function main() {
// Testing entire test suite serially
await runTests();
// Testing parallel execution on a subset that does not depend on exec order
await runTests({ parallel: true, only: /^testing/ });
}
main(); There shouldn't be two calls to |
It was to test if |
@kt3k what's the problem? EDIT: I can see the problem in current Travis build. Unfortunately I can get to debug it in the evening |
@bartlomieju @zekth I think the future we should fail noisily if runIfMain() is called more than once. |
@ry agreed, however that wouldn't prevent this error. It was |
In particular to have this improvement to http_bench.ts
depends on #2065