Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deno_std #2064

Closed
wants to merge 1 commit into from
Closed

Upgrade deno_std #2064

wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Apr 7, 2019

In particular to have this improvement to http_bench.ts

depends on #2065

@ry
Copy link
Member Author

ry commented Apr 8, 2019

This is failing because the unit test summary is printed twice for some reason.

> ./target/debug/deno --no-prompt js/unit_tests.ts permR0W0N0E0U0
[...]
test createSyscallCountColumnsIrregularData_permR0W0N0E0U0 ... ok
test createSha1ListRegularData_permR0W0N0E0U0 ... ok

test result: ok. 181 passed; 0 failed; 0 ignored; 0 measured; 112 filtered out

running 0 tests

test result: ok. 0 passed; 0 failed; 181 ignored; 0 measured; 112 filtered out

I assume this has something to do with the flag changes... Any idea @kt3k @bartlomieju ?

@kt3k
Copy link
Member

kt3k commented Apr 9, 2019

@ry
If I replaced the following line of unit_tests.ts:

import "deps/https/deno.land/std/testing/main.ts";

to the following:

import { runTests } from "deps/https/deno.land/std/testing/mod.ts";
runTests();

Then tests seem working normally (but I found another failure with deno fmt)

(Is std/testing/main.ts intended as the general entrypoint of testing?)

@bartlomieju
Copy link
Member

In testing/main.ts:

// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
import { runTests } from "./mod.ts";

async function main() {
  // Testing entire test suite serially
  await runTests();
  // Testing parallel execution on a subset that does not depend on exec order
  await runTests({ parallel: true, only: /^testing/ });
}

main();

There shouldn't be two calls to runTests. This was changed in denoland/std#309

@zekth
Copy link
Contributor

zekth commented Apr 9, 2019

It was to test if parallel and serial test running were working properly. We encountered a non tested case when changing the exitonfail property.

@bartlomieju
Copy link
Member

bartlomieju commented Apr 9, 2019

(but I found another failure with deno fmt)

@kt3k what's the problem?

EDIT: I can see the problem in current Travis build. Unfortunately I can get to debug it in the evening

ry pushed a commit to denoland/std that referenced this pull request Apr 9, 2019
@ry ry reopened this Apr 9, 2019
@ry
Copy link
Member Author

ry commented Apr 9, 2019

@bartlomieju @zekth I think the future we should fail noisily if runIfMain() is called more than once.

@bartlomieju
Copy link
Member

@ry agreed, however that wouldn't prevent this error. It was runTests that was called multiple times, and I think that might be desired actually.

@ry ry closed this Apr 10, 2019
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants