fix(ext/node): Support env option in worker_thread
#23462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyarohith
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM
It would be nice to add support for https://nodejs.org/api/worker_threads.html#workershare_env in a follow up.
bartlomieju
reviewed
Apr 20, 2024
Comment on lines
+354
to
+356
| if (env) { | ||
| process.env = env; | ||
| } |
There was a problem hiding this comment.
This is bit strange - does it mean that setting a new property won't have an effect on the whole process? Can we add a test that checks this behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23455