Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unref stdin read #23534

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: unref stdin read #23534

merged 1 commit into from
Apr 25, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju @mmastrac
fix: unref stdin read
62a2928 
Co-authored-by: Matt Mastracci <[email protected]>
mmastrac
mmastrac approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) April 24, 2024 14:39
@bartlomieju bartlomieju merged commit 115dedd into denoland:main Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core.read(stdin, buf) blocks program from exiting even when the promise is unref'd
2 participants
@bartlomieju @mmastrac