refactor: move PackageJson to deno_config #24348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 26, 2024
| @@ -1106,7 +1106,7 @@ dependencies = [ | |||
| "glibc_version", | |||
| "glob", | |||
| "ignore", | |||
| "import_map 0.20.0", | |||
| "import_map", | |||
There was a problem hiding this comment.
Oh, whoops. We accidentally have two import_map deps in main.
bartlomieju
approved these changes
Jun 26, 2024
| concat!( | ||
| "Could not find \"{}\" in a node_modules folder. ", | ||
| "Deno expects the node_modules/ directory to be up to date. ", | ||
| "Did you forget to run `npm install`?" |
There was a problem hiding this comment.
This is just moved from another place?
There was a problem hiding this comment.
We should update the message for Deno 2
There was a problem hiding this comment.
Somewhat. It's just a bit smarter now.
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on denoland/deno_config#60