fix: make .setup-cache.bin in node_modules more reproducible #24480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you add a comment so that future editors of this code don't switch it back to a |
dsherret
changed the title
The .setup-cache.bin is currently not reproducible because it consists of serialized Hashmaps which have a random order of elements. By switching them out for BTreeMaps, which are always sorted in memory, deno generates the same file every time.
zebreus
force-pushed
the
improve-reproducibility
branch
from
8b002aa
to
33de335
Compare
|
@lucacasonato @dsherret I added a comment to both changed datastructures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make vendored dependencies more deterministic. The
node_modules/.deno/.setup-cache.binis currently not deterministic because it consists of serializedHashMaps which have a random order of elements. By switching them out forBTreeMaps, which are sorted in memory, deno generates the same file every time.According to the Rust documentation
BTreeMapmight provide slightly less performance thanHashMap, but I wasn't able to reproduce lower performance in deno. I think even for large projects, our maps are way too small for this to have any performance impact.related issue: #24479