Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce run permission on kill() #2723

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Enforce run permission on kill() #2723

merged 4 commits into from
Aug 6, 2019

Conversation

nayeemrmn
Copy link
Collaborator

Closes #2722

ry
ry reviewed Aug 4, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this requirement to the jsdoc comment for kill ?

—allow-run is broad for kill- but it’s better than nothing. Adding an allow-kill seems unnecessarily specific.

@nayeemrmn
Copy link
Collaborator Author

Done. Did the env ones as well, since Deno.homeDir()'s was wrong and Deno.execPath's permission-less behaviour isn't obvious.

@nayeemrmn nayeemrmn force-pushed the kill-permissions branch 2 times, most recently from 007ab48 to d968a91 Compare August 5, 2019 14:09
@nayeemrmn nayeemrmn force-pushed the kill-permissions branch 2 times, most recently from 76a35c6 to b76fc8a Compare August 6, 2019 01:27
ry
ry approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

see #2733 also

@ry ry merged commit 11c850a into denoland:master Aug 6, 2019
@nayeemrmn nayeemrmn deleted the kill-permissions branch August 6, 2019 09:37
@piscisaureus piscisaureus mentioned this pull request Aug 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.kill() requires no permissions
2 participants
@nayeemrmn @ry