Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial implementation of node os polyfill #3821

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Jan 29, 2020

This is a partial implementation of the node os polyfill (see #3403 ). It provides implementation for the following:

  • arch()
  • homedir()
  • hostname()
  • EOL
  • constants.Signal (partial)

The following functions cannot be implemented at this time as Deno does not provide needed capabilities ( see issue #3802 ):

  • cpus()
  • endianness()
  • freemem()
  • getPriority()
  • loadavg()
  • networkInterfaces()
  • platform()
  • release()
  • setPriority()
  • tmpdir()
  • totalmem()
  • type()
  • uptime()
  • userInfo()
  • constants.UV_UDP_REUSEADDR
  • constants.dlopen
  • constants.Signal (partial)
  • constants.priority

@claassistantio
Copy link

claassistantio commented Jan 29, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - stubbing out these functions is helpful - thanks

@ry ry merged commit f0a6062 into denoland:master Jan 30, 2020
@cknight cknight deleted the nodeOsPolyfill branch March 6, 2020 22:23
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants