-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rewrite tests in std/ to use Deno.test #3930
Conversation
bartlomieju
commented
Feb 8, 2020
•
edited
Loading
edited
- rewrite all tests in "std/" to use "Deno.test()"
- remove "std/testing/mod.ts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I love these big numbers of lines removed.
Please be extra sure this isn't silently breaking tests in std and cli/js. (If you change an assert there they should still break cargo test)
Confirmed, that adding failing assertion breaks |
I asked about it on Gitter too (once I get an answer there I'll leave it here for posterity as well) but this change broke my CI. https://github.com/galkowskit/denofun/pull/43/checks?check_run_id=439140417 It looks like removal of But what would be the recommended approach for community to lock dependencies and update them later? |
@galkowskit
|
There are some references to |