Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node events polyfill: Monitor error events #3960

Merged
merged 8 commits into from
Feb 11, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Feb 11, 2020

This capability (EventEmitter.errorMonitor) was added in Node 13.6.

There is one more function to add (also added in Node 13.6) after this to complete the Node events polyfill.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit a705609 into denoland:master Feb 11, 2020
geoFlux added a commit to geoFlux/deno that referenced this pull request Feb 14, 2020
* master:
  v0.33.0
  fix: appended CRLF to end of trailer headers (denoland#3989)
  Clean up fmt flags and path handling (denoland#3988)
  Improvements to bundling. (denoland#3965)
  fix: Correctly determine a --cached-only error (denoland#3979)
  chore: share HTTP server between tests (denoland#3966)
  dont use env vars in multiple installer tests (denoland#3967)
  feat(node): add EventEmitter.errorMonitor (denoland#3960)
  fix(file_server): don't crash on "%" pathname (denoland#3953)
  update references to testing/mod.ts in manual (denoland#3973)
@cknight cknight deleted the monitorErrorEvents branch March 6, 2020 22:23
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants