[WIP] json output from runTests #4235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
reviewed
Mar 3, 2020
Comment on lines
+246
to
+257
| [Symbol.asyncIterator](): AsyncIterableIterator<RunTestsMessage> { | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Can we use an async generator instead of a next() method?
There was a problem hiding this comment.
I'm open to that, is there an advantage doing that?
There was a problem hiding this comment.
Then no ugly next() method is exposed. I've been meaning to get rid of the one in Listener.
Just realised this class is private, though. Who cares.
There was a problem hiding this comment.
Still should be consistent... would rather have async generator methods. I don't know if it empowers V8 to optimise stuff behind the scenes or not, but it could. If you implement the shape of a generator, it may limit V8s ability to optimise.
bartlomieju
force-pushed
the
run_tests_iterator
branch
from
647e373
to
04cd048
Compare
bartlomieju
force-pushed
the
run_tests_iterator
branch
from
1943884
to
7524e5d
Compare
|
Closing in favor of #4336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement JSON output from
runTestsand use it incli/js/unit_test_runner.ts.At the moment
unit_test_runner.tsparses text output fromrunTests(); so parsing JSON seems like a more robust solution than using RegExps. There are, however, some quirks that it needs to account for; eg.await Deno.stdout.write()will still be visible in output so consumer need to account for that fact.Ref #4166
CC @kitsonk