Revert "avoid using same port number for test (#4147)" #4478
Conversation
This reverts commit 60cee4f.
|
It's strange to get |
|
@keroxp there are multiple |
|
@bartlomieju Could we pass the first port to use in the cli for the unit test runner? |
|
I don't think that's necessary, before using random ports, there were no problems with |
|
BTW the kernel has the functionality to choose a random unused port. We should use that rather than choosing a random number and hoping that it is unused. |
| @@ -1,6 +1,6 @@ | |||
| // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. | |||
| const hostname = "0.0.0.0"; | |||
| const port = +(Deno.args[0] ?? "8080"); | |||
| const port = 8080; | |||
There was a problem hiding this comment.
@bartlomieju Would you limit port range around 4500?
| const serverRoutine = async (): Promise<void> => { | ||
| const server = serve(":" + port); | ||
| const server = serve(":8124"); |
There was a problem hiding this comment.
Let's revert and do another fix up patch rather than conflate the two. It will be easier to manage the changes.
|
Anyway very sorry for making test more flaky... |
|
@keroxp no worries - it happens! |
This reverts commit 60cee4f.
Closes #4467
CC @keroxp