[WIP] Use dprint for internal js/ts formating

[keroxp]

• fixes Migrate from prettier to dprint for internal formatting #4307

---

• Dprint - Use cargo run fmt with latest deno build
• Code adaption for dprint bug
  • All error syntaxes (for dprint) have been fixed.
• Excluded files -- currently there's no way to exclude specified files for deno fmt
  • .prettierignore doesn't work
• Build for per formatting - Because cargo run will re-build entire project...
• Huge stdout
  • cargo run shows all expanded glob arguments...

[bartlomieju]

Hey @keroxp I'm very glad you're tackled this issue!

Just yesterday @dsherret merged PR to add Rust shell to dprint (dprint/dprint#162), and it's now available on https://crates.io/crates/dprint.
That means you should be able to cargo install dprint just like for rustfmt. It's a simple shell that works almost the same as deno fmt, the only difference is that dprint doesn't walk directory tree to find files, but requires to pass all of them as CLI arguments.

Keep in mind that there are still some quirks for Deno codebase when using dprint.

[kitsonk]

Also, although this is great, we should merge #4498 first as it includes a move to ES private fields which was blocked because of a lack of Prettier support. I "could" unpick it, but it is complex.

I also agree that we should use the standalone binary, instead of another version of Deno.

[bartlomieju]

Also, although this is great, we should merge #4498 first as it includes a move to ES private fields which was blocked because of a lack of Prettier support. I "could" unpick it, but it is complex.

I also agree that we should use the standalone binary, instead of another version of Deno.

@kitsonk, yeah agreed #4498 should be landed first

[dsherret]

This was fixed in swc so is not necessary anymore.

[dsherret]

Before you actually run it on the code, could we wait until this milestone is resolved in dprint? https://github.com/dsherret/dprint/milestone/2

It's way less problems than before, but still a bit of work to do. Might be two more weeks or so :)

[keroxp]

@dsherret Yes, this may be too early adaption to dprint. I'll re-try after that.