-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: BorrowMutError when evaluating expression in inspector console #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 24, 2020 21:05
3746755
to
039882e
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 24, 2020
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 24, 2020 22:59
039882e
to
abb5d9b
Compare
piscisaureus
changed the title
[WIP] Fix crash when evaluating expression in inspector console
Fix crash when evaluating expression in inspector console
May 24, 2020
piscisaureus
changed the title
Fix crash when evaluating expression in inspector console
fix: BorrowMutError when evaluating expression in inspector console
May 24, 2020
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 24, 2020
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 24, 2020 23:03
abb5d9b
to
cd78bd4
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 24, 2020
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 24, 2020 23:40
cd78bd4
to
045796e
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 25, 2020
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 25, 2020
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 25, 2020 00:12
1b3cac6
to
f3ec33a
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 25, 2020
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 25, 2020 00:46
f3ec33a
to
ae81e69
Compare
piscisaureus
added a commit
to piscisaureus/deno
that referenced
this pull request
May 25, 2020
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 25, 2020 02:20
ae81e69
to
36ffd68
Compare
…enoland#5822) Note that this does not fix the 'Uncaught ReferenceError' issue that happens when 'eager evaluation' is enabled in the inspector. Fixes: denoland#5807
piscisaureus
force-pushed
the
inspector_crash
branch
from
May 25, 2020 02:26
36ffd68
to
131f2a5
Compare
ry
approved these changes
May 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.
Fixes: #5807