Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BorrowMutError when evaluating expression in inspector console #5822

Merged
merged 2 commits into from
May 25, 2020

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented May 24, 2020

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: #5807

piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 24, 2020
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
@piscisaureus piscisaureus changed the title [WIP] Fix crash when evaluating expression in inspector console Fix crash when evaluating expression in inspector console May 24, 2020
@piscisaureus piscisaureus changed the title Fix crash when evaluating expression in inspector console fix: BorrowMutError when evaluating expression in inspector console May 24, 2020
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 24, 2020
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 24, 2020
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
@piscisaureus piscisaureus reopened this May 25, 2020
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 25, 2020
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
piscisaureus added a commit to piscisaureus/deno that referenced this pull request May 25, 2020
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
…enoland#5822)

Note that this does not fix the 'Uncaught ReferenceError' issue that
happens when 'eager evaluation' is enabled in the inspector.

Fixes: denoland#5807
@piscisaureus piscisaureus reopened this May 25, 2020
@piscisaureus piscisaureus requested review from ry and bartlomieju and removed request for ry May 25, 2020 03:06
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piscisaureus piscisaureus merged commit 131f2a5 into denoland:master May 25, 2020
@piscisaureus piscisaureus deleted the inspector_crash branch May 25, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector causes Rust runtime crash
2 participants