Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing of JSX and TSX in SWC #5870

Merged
merged 3 commits into from
May 26, 2020
Merged

fix: parsing of JSX and TSX in SWC #5870

merged 3 commits into from
May 26, 2020

Conversation

bartlomieju
Copy link
Member

Fixes: #5867

@bartlomieju bartlomieju added bug Something isn't working correctly cli related to cli/ dir labels May 26, 2020
@bartlomieju bartlomieju mentioned this pull request May 26, 2020
Closed
ry
ry approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but I wonder if you could make this into a rust unit test rather than an integration test? Seems like it might be an easy change - and it would speed up the tests.

@bartlomieju
Copy link
Member Author

bartlomieju commented May 26, 2020 •
edited
Loading

LGTM - but I wonder if you could make this into a rust unit test rather than an integration test? Seems like it might be an easy change - and it would speed up the tests.

I don't agree, if I make it a unit test then I'm gonna have to manually extract extension/media type - so I will not test the actual logic that was faulty. Nvm, I'll rewrite it

@bartlomieju bartlomieju merged commit f462f7f into denoland:master May 26, 2020
@bartlomieju bartlomieju deleted the fix_swc_parsing branch May 26, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error on master with properties named delete
2 participants
@bartlomieju @ry