Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(unstable): Support data: urls (#5157)" #7432

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 12, 2020

This reverts commit e3319f3.

https://discord.com/channels/684898665143206084/684911491035430919/754091114008543252

Using data: URLs breaks .tsbuildinfo that we use for caching TS output. Unfortunately it wasn't caught in tests.

CC @SyrupThinker @nayeemrmn @kitsonk

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As this is unstable we can re-land in any patch release.

@bartlomieju bartlomieju merged commit 60dbc6b into denoland:master Sep 12, 2020
@bartlomieju bartlomieju deleted the revert_5157 branch September 12, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants