Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: disable URL.createObjectUrl #7543

Merged
merged 1 commit into from
Sep 17, 2020
Merged

refactor: disable URL.createObjectUrl #7543

merged 1 commit into from
Sep 17, 2020

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju requested a review from ry September 17, 2020 15:24
@bartlomieju bartlomieju mentioned this pull request Sep 17, 2020
Merged
@lucacasonato
Copy link
Member

lucacasonato commented Sep 17, 2020 •
edited
Loading

Why? I assume the random number?

ry
ry approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member Author

Why? I assume the random number?

Yes, it's easier to move it to a separate crate that way.

@bartlomieju bartlomieju merged commit 3421f4d into denoland:master Sep 17, 2020
@bartlomieju bartlomieju deleted the disable_url_create_object_url branch September 17, 2020 15:35
vitormmatos pushed a commit to vitormmatos/deno that referenced this pull request Sep 21, 2020
@bartlomieju
refactor: disable URL.createObjectUrl (denoland#7543)
129423b
@EliteScientist EliteScientist mentioned this pull request Oct 8, 2020
Merged
@evanw evanw mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @lucacasonato @ry