Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/ops/fs): Don't replace Windows path separators #7833

Merged
merged 7 commits into from
Oct 7, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #5685.
Closes #6073.

@kitsonk
Copy link
Contributor

kitsonk commented Oct 5, 2020

Looks like there are legitimate failures related to the changes in this PR: https://github.com/denoland/deno/pull/7833/checks?check_run_id=1211730569#step:16:1514

@piscisaureus piscisaureus merged commit c226d3a into denoland:master Oct 7, 2020
@piscisaureus
Copy link
Member

Thanks @nayeemrmn, we needed this!
I messed up the commit message - sorry about that.

@nayeemrmn nayeemrmn deleted the real-path-windows-separator branch October 7, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

realPathSync returns paths with UNIX "/" separator on Windows
3 participants