Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ergonomic brand checks for private fields in JS #30

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 27, 2021

Relates to #12565. Seems like this is not supported in TS yet... would be nice if it at least parsed though Edit: actually, this will be in 4.5. Edit 2: opened swc-project/swc#2562

cc @lucacasonato

@dsherret dsherret requested a review from kitsonk October 27, 2021 23:37
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 47d988e into denoland:main Oct 28, 2021
@dsherret dsherret deleted the brand_checks branch October 28, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants