Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ops): Deprecate decl() in favour of const DECL and remove access for functions #26

Merged
merged 1 commit into from
Jul 9, 2023
Merged

feat(ops): Deprecate decl() in favour of const DECL and remove access for functions #26

merged 1 commit into from
Jul 9, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Jul 9, 2023 •
edited
Loading

Allowing embedders to access fast and slow functions was a footgun -- code was copying the slow function without copying the fast function as well.

Fixes #24

@mmastrac mmastrac mentioned this pull request Jul 9, 2023
Closed
bartlomieju
bartlomieju approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great line number reduction!

@mmastrac mmastrac merged commit 7e84976 into denoland:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose v8_fn_ptr from an op
2 participants
@mmastrac @bartlomieju