Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypto module #48

Closed
bartlomieju opened this issue Dec 27, 2018 · 4 comments
Closed

Add crypto module #48

bartlomieju opened this issue Dec 27, 2018 · 4 comments

Comments

@bartlomieju
Copy link
Member

SHA1 is required for #29

@hayd
Copy link
Contributor

hayd commented Dec 28, 2018

The best long-term solution is to get this by including webcrypto via gn in main deno.

@dsseng
Copy link
Contributor

dsseng commented Dec 31, 2018

I'll try to make simple sha1 hash function in TS.

@hayd
Copy link
Contributor

hayd commented Dec 31, 2018

See e.g. https://github.com/keroxp/deno-ws/blob/master/crypt.ts

@ry
Copy link
Member

ry commented Dec 31, 2018

Probably @hayd is correct that webcrypto would be best (so this issue should be in deno instead of deno_std)
I have to investigate further - but it looks like one road block is to get //base working... We'd have to weigh the benefits of that against rolling our own. //base would introduce a lot of duplicated code that's already in Rust, for example.
In any case, there are several refactors that we need to complete before addressing this - in particular denoland/deno#975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants