feat(async): add status to deferred promises #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. Because |
kt3k
reviewed
Jul 21, 2021
kt3k
reviewed
Jul 22, 2021
| const e = deferred<string>(); | ||
| assertEquals(d.status, "pending"); | ||
| d.resolve(e); | ||
| assertEquals(d.status, "pending"); |
kt3k
approved these changes
Jul 22, 2021
kitsonk
reviewed
Jul 22, 2021
| @@ -5,6 +5,7 @@ | |||
| // See https://github.com/Microsoft/TypeScript/issues/15202 | |||
| // At the time of writing, the github issue is closed but the problem remains. | |||
| export interface Deferred<T> extends Promise<T> { | |||
| status: "pending" | "fulfilled" | "rejected"; | |||
There was a problem hiding this comment.
In the ECMAScript specification, the internal field is called [[PromiseState]], so I think state would be better name.
|
Also, just to mention, why wouldn't we want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edits a bit
deferred<T>in order to be able to track promise status, which is not exposed directly by default.It's mostly useful to know whether the deferred promise is still
pendingor not (as they're manually resolved)Personnaly I sometimes use it in unit testing so I figured out it may be useful for others too, though I could understand it may not be that revelant 🙂