Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node/_tools/setup): Improve cli messages #1446

Closed
wants to merge 2 commits into from
Closed

chore(node/_tools/setup): Improve cli messages #1446

wants to merge 2 commits into from

Conversation

wafuwafu13
Copy link
Contributor

Before

スクリーンショット 2021-10-22 17 23 32

After

スクリーンショット 2021-10-22 17 24 46

@wafuwafu13
Copy link
Contributor Author

https://github.com/denoland/deno_std/runs/3973548880?check_suite_focus=true#step:4:4338

Related: #1439

@kt3k
Copy link
Member

kt3k commented Oct 23, 2021

I'm not in favor of this change. Especially the usage of emojis look excessive to me.

ref: denoland/deno#328 (comment) , denoland/deno#998 (comment)

@wafuwafu13
Copy link
Contributor Author

wafuwafu13 commented Oct 24, 2021 •
edited
Loading

This PR is a matter of personal taste, so close :)

@wafuwafu13 wafuwafu13 closed this Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wafuwafu13 @kt3k