fs.walk #192
Merged
fs.walk #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Feb 13, 2019
fs/walk.ts
Outdated
| } | ||
|
|
||
|
|
||
| export function *walk(dir: string, options: WalkOptions = {}): IterableIterator<FileInfo> { |
ry
reviewed
Feb 13, 2019
fs/walk_test.ts
Outdated
| await mkdir(d + "/dir_empty"); | ||
| }, | ||
| function emptyDir() { | ||
| const arr = Array.from(walk("."), (f: FileInfo) => f.path); |
ry
reviewed
Feb 13, 2019
| remove(d, {recursive: true}); | ||
| } | ||
| } | ||
| test({ name, fn }); |
There was a problem hiding this comment.
I like this pattern of wrapping the test function for setup.
There was a problem hiding this comment.
Bert suggested this in discussion of setup/teardown for testFileserver - I should push a branch with that change too...
bartlomieju
reviewed
Feb 13, 2019
|
Is symlink not supported in windows? |
|
@ry does this suffice for jsdoc? This supports lots of options now, and has both async and sync versions. |
ry
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#189