Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/fs/exists): fix promisified exists #2409

Merged
merged 1 commit into from
Jul 2, 2022
Merged

fix(node/fs/exists): fix promisified exists #2409

merged 1 commit into from
Jul 2, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 2, 2022

fs.exists has non-standard callback signature. We need to provide special implementation for promisify via the special property Symbol.for("nodejs.util.promisify.custom")

cf. nodejs/node#13316

@kt3k kt3k requested a review from bartlomieju as a code owner July 2, 2022 09:18
bartlomieju
bartlomieju approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This fixes the problem I've encountered

@kt3k kt3k merged commit a121634 into denoland:main Jul 2, 2022
@kt3k kt3k deleted the fix-promisify-exists branch July 2, 2022 09:41
@cjihrig cjihrig mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju