Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(encoding): added XML parser #2471

Closed
wants to merge 2 commits into from
Closed

feat(encoding): added XML parser #2471

wants to merge 2 commits into from

Conversation

JuanM04
Copy link

@JuanM04 JuanM04 commented Jul 27, 2022

To-do:

  • Implement parser
    • Add multiple outputs
    • Add tests
  • Implement stringify
    • Add tests
    • Support multiple inputs (?)
  • Added escape utility

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2022

CLA assistant check
All committers have signed the CLA.

@kitsonk
Copy link
Contributor

kitsonk commented Jul 27, 2022

This is a lot of work. Has there been a conversation with a core team member about this being a good contribution to deno_std? If so, it would be great to link to it or an issue where conversation has gone on.

@JuanM04
Copy link
Author

JuanM04 commented Jul 27, 2022

I did not have any conversation about this. I was experimenting with XML and, since Deno has support for YAML, TOML, CSV, and other common formats, I thought it would be a nice addition. If you don't think it should be integrated in deno_std, I could easily extract it into its own package

@kt3k
Copy link
Member

kt3k commented Aug 1, 2022

Is it possible to make this compatible with DOMParser API?

@andreubotella
Copy link
Contributor

andreubotella commented Aug 1, 2022

Note that @b-fuze is independently thinking of adding integration with the XML parser xml5_ever in their deno_dom library (as per a conversation on the Deno discord).

@kitsonk
Copy link
Contributor

kitsonk commented Aug 1, 2022

Having XML parser as part of deno_dom would be a lot better in my opinion. YAML, TOML, CSV are far more simplistic of parsers than XML.

@crowlKats crowlKats mentioned this pull request Aug 2, 2022
@cjihrig
Copy link
Contributor

cjihrig commented Oct 4, 2022

This has been idle for a few months. @kitsonk @kt3k do we want to move forward with this? If not, can we close it out?

@kt3k
Copy link
Member

kt3k commented Oct 4, 2022

I'm in favor of closing this one for now.

I agree with @kitsonk . I think we should have xml parser as part of DOM API instead of invented API.

@JuanM04 JuanM04 closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants