refactor(archive): replace FileTypes enum with const object #3845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to this issue
This change was a little bit tricky because the exposed interfaces do not enforce
FileTypes
in the input they receive. The oldenum
also wasn't exposed via the module API.Consequently, the implementations also don't really trust their input but it seems that failing to provide a correct filetype doesn't necessarily lead to a panic.
I've tried to make this change as minimally invasive as possible, but IMO it doesn't improve anything. Maybe this refactor should be completed in tandem with the stabilization of the
archive
module API to actually contribute something to the overall maintainability and quality of this module.