-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
walk() should not use deprecated FileInfo.path #398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
changed the title
Walk file info path
walk() should not use deprecated FileInfo.path
May 13, 2019
This was referenced May 13, 2019
The walk() interface is change to return a WalkInfo object which contains both the resolved filename and FileInfo object from stat. The followSymlinks feature is disabled for now.
kt3k
reviewed
May 14, 2019
kt3k
approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
piscisaureus
approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, although it does look like a no-improvement regression as it cant walk symlinks any more.
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
The walk() interface is change to return a WalkInfo object which contains both the resolved filename and FileInfo object from stat. The followSymlinks feature is disabled for now. Original: denoland/std@07ca4f9
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
walk() made extensive use of
FileInfo.path
which will be removed in future versions.cc @kt3k
Note: this is necessary to bump CI to v0.5 #393
Necessary for denoland/deno#2313 too