Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(io): move types file #4133

Merged
merged 2 commits into from
Jan 9, 2024
Merged

deprecation(io): move types file #4133

merged 2 commits into from
Jan 9, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 8, 2024

Doing as a breaking change as the change is a simple rename.

See https://youtu.be/zu-EgnbmcLY?feature=shared
See microsoft/TypeScript#52593 (comment)

@kt3k
Copy link
Member

kt3k commented Jan 9, 2024

I think we still should do deprecation first.

/**
* An abstract interface which when implemented provides an interface to read bytes into an array buffer asynchronously.
*
* @deprecated (will be removed in 1.0.0) Use {@linkcode ReadableStream} instead.
Copy link
Contributor Author

@iuioiua iuioiua Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: remove this and other instances if we bring back std/io.

@kt3k kt3k changed the title BREAKING(io): move types file deprecation(io): move types file Jan 9, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 22fba79 into main Jan 9, 2024
12 checks passed
@iuioiua iuioiua deleted the move-types branch January 9, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants