[http] fixing content-length checking #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this done in Go? |
It's kind of the same way but our API is not really tied to the golang in some parts. It's inspired of: https://github.com/golang/go/blob/master/src/net/http/transfer.go#L670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in : #419
Fixing readRequest for the content length chekcking.
Note: https://github.com/denoland/deno_std/compare/master...zekth:fix_readRq?expand=1#diff-58b0092e6441ae4b79fb3069e2ba21ddR359
This one is still not working because of the trimming of the
kvin textproto:https://github.com/denoland/deno_std/blob/master/textproto/mod.ts#L114
I think it can stay like this for the moment