Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebSocket] Add sec-websocket-version to handshake header #468

Merged
merged 1 commit into from
May 30, 2019
Merged

[WebSocket] Add sec-websocket-version to handshake header #468

merged 1 commit into from
May 30, 2019

Conversation

hashrock
Copy link
Contributor

@hashrock hashrock commented May 30, 2019

I tried to communicate with deno_std WebSocket Client and a WebSocket Endpoint of Chrome DevTools, but handshake was rejected by Chrome.

I had to add a sec-websocket-version field to the request header to fix this.

According to the RFC, sec-websocket-version is required for the WebSocket Client implementation.

The request MUST include a header field with the name |Sec-WebSocket-Version|. The value of this header field MUST be 13.

https://tools.ietf.org/html/rfc6455#page-60

cc: @keroxp

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 40f55da into denoland:master May 30, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants