chore: make CI config DRY #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
May 30, 2019
ry
reviewed
May 30, 2019
.ci/steps.win.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| steps: | |||
There was a problem hiding this comment.
I thought about it, but won't it be confusing for users? It'll look like one of the available modules.
|
@ry this should be ready for review |
ry
reviewed
May 31, 2019
| - bash: npm install eslint typescript@$(TS_VERSION) @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint-config-prettier | ||
| - powershell: iwr https://deno.land/x/install/install.ps1 -out install.ps1; .\install.ps1 $(DENO_VERSION) | ||
| - bash: echo "##vso[task.prependpath]C:\Users\VssAdministrator\.deno\\bin" | ||
| - bash: npx eslint **/*.ts --max-warnings=0 |
There was a problem hiding this comment.
Nope, it's run with npx on Linux and Windows, but not on Mac. I tried running it with npx under Mac as well, but there's not npx
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Closes denoland#478 Related denoland#470
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Changes: 1. Notifications use ULIDs for their IDs. 2. Removes the `notifications` index from KV, as it seems unnecessary. 3. Removed the `createdAt` property from notifications. 4. Removes `newNotificationProps()`, as it now seems unnecessary. Closes denoland#473 Towards denoland#470 CC @lino-levan (this might be a good reference to learn more about ULIDs)
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Description This PR fixes denoland#470 Notes for Reviewers rename and restructure /tools folder --------- Signed-off-by: Jigar Rathod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Using templates to configure CI to dry up configuration