Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: make port BufReader.readByte() return number | EOF #472

Merged
merged 1 commit into from
May 31, 2019
Merged

io: make port BufReader.readByte() return number | EOF #472

merged 1 commit into from
May 31, 2019

Conversation

piscisaureus
Copy link
Member

No description provided.

@piscisaureus piscisaureus requested a review from ry May 31, 2019 01:22
@piscisaureus
Copy link
Member Author

piscisaureus commented May 31, 2019 •
edited
Loading

Note that the readShort(), readInt(), readLong() and sliceToLong() APIs currently are incredibly inefficient (as in probably 1000000x slower than they can be), e.g. one readLong() call is broken up into 15 microtask queue runs.
This patch doesn't change that.

ry
ry approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piscisaureus piscisaureus merged commit 679b203 into denoland:master May 31, 2019
@piscisaureus piscisaureus deleted the bufio2 branch May 31, 2019 01:38
@syumai syumai mentioned this pull request Jun 6, 2019
Closed
@bartlomieju bartlomieju mentioned this pull request Jun 26, 2019
Closed
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@roberto-morado @iuioiua
fix: avoid showing "No items found" stats in <ItemsList /> (denolan…
3a193e1 
…d#559)

fixes denoland#472 

@iuioiua this is as simple as I got, without being too intrusive; I
personally like it; the problem was a bug regarding the state change of
the variable `isLoadingSig`, I was able to avoid it by initializing the
variable as `undefined` and bypassing it with the conditional rendering
not sure if is worth taking another look at it some other time.

Note: The simplicity of this PR does not reflect at all the time that
took me to get there — just for the record.

---------

Co-authored-by: Asher Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @ry