bundle/run handles Deno.args better. #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axetroy
added a commit
to axetroy/deno_std
that referenced
this pull request
Jun 24, 2019
add test case for reading code from stdin and format update update update update update update update update update update update update update update update improve installer (denoland#512) - remove uninstall command - add --reload to deno fetch - to ensure subsequent installation upgrades script and deps - fix executable shebang - fix prompt for subsequent installation - support custom installation dir via -d/--dir flag typo (denoland#515) bundle/run handles Deno.args better. (denoland#514) fix: pin eslint version for CI (denoland#518) typescript-eslint/typescript-eslint#637 feat: add catjson example (denoland#517) file server should order filenames (denoland#511) update update update update update update update update update update
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Prerequisite for denoland#514.
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
Please pay attention to the migration script, as it's responsible for migrating all items and votes. I've also changed all instances of `monotonicUlid()` to `ulid()` at there appears to be a bug that prevents `monotonicUlid()` from respecting the `seedTime` parameter. The migration can be simulated as follows: 1. Switch to **main** branch. 2. Run `deno run db:reset`. 3. Run `deno run db:seed`. 4. Run `deno task start` and navigate to `http://localhost:8000`. 6. Vote some items. 7. Note the voted items and the order of the items feed. 8. Switch to **ulid-items** branch. 9. Run `deno run db:migrate`. 10. Run `deno task start` and navigate to `http://localhost:8000`. 11. Check that the voted items and the order of the items feed are identical to those previously noted. Closes denoland#475 Closes denoland#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513