Add userHomeDir #521
Merged
Add userHomeDir #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekaragodin
force-pushed
the
add-os-user-home-dir
branch
2 times, most recently
from
80d8194
to
9346ca5
Compare
ry
reviewed
Jun 24, 2019
| * On Unix, including macOS, it returns the $HOME environment variable. | ||
| * On Windows, it returns %USERPROFILE%. | ||
| * | ||
| * Ported from Go: https://github.com/golang/go/blob/go1.12.5/src/os/file.go#L389 |
There was a problem hiding this comment.
Add "Needs permissions to access env (--allow-env)."
ekaragodin
force-pushed
the
add-os-user-home-dir
branch
from
9346ca5
to
f7ea043
Compare
|
it looks superfluous for me. Isn't it better to implement in |
|
@axetroy I was thinking that too. We would be able to avoid the env access by adding an op. |
|
@ry I don't have enough experience with rust, but I tried denoland/deno#2578 |
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.