Accept absolute root directories in the file server #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
force-pushed
the
file-server-abs-target
branch
3 times, most recently
from
7f126ac
to
e894e8e
Compare
bartlomieju
approved these changes
Aug 12, 2019
nayeemrmn
force-pushed
the
file-server-abs-target
branch
from
e894e8e
to
db6b3d6
Compare
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
The `cov:view` task generates HTML to view LCOV files using [`genhtml`](https://linux.die.net/man/1/genhtml) and then opens the main page in the local machine's browser. This is good for analysing test coverage locally. The `cov` task has also been renamed to `cov:gen`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #557.
Also some refactors:
pathutility functions are used where appropriate.filePath/dirPathis an absolute FS path to a file or directory, whereasfileUrl/dirUrlis a syntactically absolute path but relative to the served root, consistent withreq.url. The latter were confusingly calledfileName/dirNamebefore.