Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better paths handling in test runner #574

Merged
merged 9 commits into from
Aug 30, 2019
Merged

fix: better paths handling in test runner #574

merged 9 commits into from
Aug 30, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 27, 2019

Fixes #570
Fixes #569

@bartlomieju
Copy link
Member Author

deno -A ./testing/runner.ts https://deno.land/std/fmt/sprintf_test.ts
Compile file:///Users/biwanczuk/dev/deno_std/testing/mod.ts
Found 1 matching test files.
running 29 tests
OK     noVerb (0.34ms)
OK     percent (0.09ms)
OK     testBoolean (0.43ms)
OK     testIntegerB (0.62ms)
OK     testIntegerC (0.14ms)
OK     testIntegerD (0.11ms)
OK     testIntegerO (0.11ms)
OK     testIntegerx (0.26ms)
OK     testIntegerX (0.10ms)
OK     testFloate (0.37ms)
OK     testFloatE (0.15ms)
OK     testFloatfF (0.46ms)
OK     testString (0.09ms)
OK     testHex (0.07ms)
OK     testHeX (0.06ms)
OK     testType (0.08ms)
OK     testPositional (0.13ms)
OK     testSharp (0.13ms)
OK     testWidthAndPrecision (0.23ms)
OK     testDash (0.07ms)
OK     testPlus (0.08ms)
OK     testSpace (0.07ms)
OK     testZero (0.06ms)
OK     testThorough (2.15ms)
OK     testWeirdos (0.10ms)
OK     formatV (0.50ms)
OK     formatJ (0.08ms)
OK     flagLessThan (0.23ms)
OK     testErrors (0.33ms)

test result: OK 29 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (10.81ms)

@bartlomieju bartlomieju changed the title feat: handle remote files in test runner fix: better paths handling in test runner Aug 27, 2019
Copy link
Contributor

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add -S to the shebang? Ref #545.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 5ef42ec into denoland:master Aug 30, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno test doesn't work with URLs deno test doesn't work on subdirs
3 participants