Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix(node): Fix assert implementation and enable assert test suite #705

Closed
wants to merge 1 commit into from

Conversation

Soremwar
Copy link
Contributor

@Soremwar Soremwar commented Feb 4, 2021

Based on #695

@Soremwar Soremwar marked this pull request as draft February 11, 2021 03:50
@ry ry self-assigned this Feb 24, 2021
@caspervonb
Copy link
Contributor

caspervonb commented Feb 26, 2021

We're adding tests for assert here but the actual assertions are based on testing/assert.ts behavior.

Do you plan on porting over over Node's current implementation from https://github.com/nodejs/node/blob/master/lib/assert.js here @Soremwar?

@ry ry assigned kt3k and unassigned ry Feb 26, 2021
@Soremwar
Copy link
Contributor Author

Soremwar commented Mar 5, 2021

Superseded by #769 . Awesome work @kt3k

@Soremwar Soremwar closed this Mar 5, 2021
@Soremwar Soremwar deleted the assert branch March 5, 2021 02:47
@kt3k
Copy link
Member

kt3k commented Mar 5, 2021

@Soremwar Thank you for your initial work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants