Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(io/ioutil.ts): add jsdoc #706

Merged
merged 1 commit into from
Feb 6, 2021
Merged

docs(io/ioutil.ts): add jsdoc #706

merged 1 commit into from
Feb 6, 2021

Conversation

grian32
Copy link
Contributor

@grian32 grian32 commented Feb 4, 2021

I wasn't sure what to put for the r and dest parameters for copyN so i just put Reader and Writer.

Didn't add any description for buf parameters because it's very self explanatory.

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kt3k
kt3k approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grian32 You might also be interested in #654

@kt3k kt3k merged commit bcdbfea into denoland:main Feb 6, 2021
@grian32 grian32 mentioned this pull request Feb 10, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grian32 @CLAassistant @kt3k