feat(encoding/yaml): Add support for JS types and user types #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Mar 10, 2021
kt3k
reviewed
Mar 10, 2021
lowlighter
commented
Mar 10, 2021
| }; | ||
|
|
||
| const expected = `regexp: | ||
| simple: !<tag:yaml.org,2002:js/regexp> /foobar/ |
There was a problem hiding this comment.
so unfortunately, in js-yaml 3 (ported version of Deno), custom tags were dumped with !<tag:yaml.orf,2022:..>, and it has been fixed in v4 (nodeca/js-yaml@a0d0caa)
it does works though, it's just the display which is a bit more verbose and less pretty
kt3k
reviewed
Mar 11, 2021
|
|
||
| Deno.test({ | ||
| name: | ||
| "`!!js/*` yaml types are correctly handled with extended schema while stringifying", |
kt3k
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Tests look very well (It has 81% diff coverage ref: https://github.com/denoland/deno_std/pull/789/checks?check_run_id=2079608904)
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends current YAML support with an
EXTENDED_SCHEMAwhich supports!!js/regexp,!!js/functionand!!js/undefinedto remove current Deno limitation (heavily based on nodeca/js-yaml-js-types but reworked a bit to be more succint).This also exposes the
Typefunction (which is already implemented but not available to end-users) to allow the creation of custom types with!tagsas defined in YAML spec.