ci: Collect coverage from native node tests #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This being required sounds like an upstream Deno bug. cc @caspervonb |
|
Yeah upstream issue, the CLI should be canonicalizing the coverage directory before storing it in env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it looks like the coverage is not being collected from native node tests (https://github.com/denoland/deno_std/runs/2426282821) This PR fixes this problem.
Cause
In the following code,
cwdis set tonode/_toolsdirectory:https://github.com/denoland/deno_std/blob/3931030e7fae16158e3b6cb041a2a161c0cba6e3/node/_tools/test.ts#L21-L35
This will cause Deno to create coverage profile in the
node/_toolsdirectory instead of the project root directory.