Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor decorations disappear/flicker while typing #835

Closed
Tracked by #879
klaussner opened this issue Apr 12, 2023 · 0 comments · Fixed by denoland/deno#19803
Closed
Tracked by #879

Editor decorations disappear/flicker while typing #835

klaussner opened this issue Apr 12, 2023 · 0 comments · Fixed by denoland/deno#19803
Assignees
@dsherret
Labels
bug Something isn't working dx high priority

Comments

@klaussner
Copy link

Describe the bug

Editor decorations like error squiggly lines disappear/flicker while typing, which is a little irritating. The problem may be related to #689, but I'm not sure.

To Reproduce

  1. Open a TypeScript file in a project where the Deno extension is enabled.
  2. Write some code with error squiggly lines.
  3. Type something to see the issue.

Expected behavior

Editor decorations should not change while typing.

Video

The first part of the video shows the flickering issue. The second part shows that the problem no longer exists if the Deno extension is disabled and the default VS Code TypeScript integration is used instead.

Deno-VS-Code.mp4

Versions

vscode: 1.77.3 deno: 1.32.2 extension: 3.17.0
@bartlomieju bartlomieju added bug Something isn't working high priority dx labels Jul 10, 2023
@dsherret dsherret self-assigned this Jul 11, 2023
This was referenced Jul 11, 2023
Merged
Merged
dsherret added a commit to denoland/deno that referenced this issue Jul 11, 2023
@dsherret
refactor(lsp): update diagnostics.rs to use structs instead of records (
830d10b 
#19799)

Part of denoland/vscode_deno#835
dsherret added a commit to denoland/deno that referenced this issue Jul 11, 2023
@dsherret
fix(lsp): stop diagnostics flickering (#19803)
80331d1 
Closes denoland/vscode_deno#835
@bartlomieju bartlomieju mentioned this issue Jul 11, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working dx high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): stop diagnostics flickering dsherret/deno
3 participants
@klaussner @dsherret @bartlomieju