Fix error loading "text" syntax for hover #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liskin
force-pushed
the
fix-hover-syntax-text
branch
from
e7179c7
to
36ace32
Compare
w0rp
requested changes
Aug 5, 2023
rust-analyzer sometimes returns a hover result with language being
"text", but there's no syntax/text.vim, so this would fail with:
Error detected while processing function <SNR>150_VimOutputCallback[6]..<lambda>8[1]..ale#lsp#HandleMessage[30]..ale#hover#HandleLSPResponse[42]..ale#floating_preview#Show[13]..<SNR>161_VimShow:
line 13:
E484: Cannot open file syntax/text.vim
Only including the file when it actually exists fixes this.
(Note that I had to substitute javascript for typescript in
test/test_hover_parsing.vader because there's no syntax/typescript.vim
in vim 8.0 and neovim 0.2. Likewise for python/rust in
test/test_hover.vim.)
liskin
force-pushed
the
fix-hover-syntax-text
branch
from
36ace32
to
04c1235
Compare
w0rp
approved these changes
Aug 15, 2023
|
Cheers! 🍻 |
mnikulin
pushed a commit
to mnikulin/ale
that referenced
this pull request
Nov 12, 2023
rust-analyzer sometimes returns a hover result with language being
"text", but there's no syntax/text.vim, so this would fail with:
Error detected while processing function <SNR>150_VimOutputCallback[6]..<lambda>8[1]..ale#lsp#HandleMessage[30]..ale#hover#HandleLSPResponse[42]..ale#floating_preview#Show[13]..<SNR>161_VimShow:
line 13:
E484: Cannot open file syntax/text.vim
Only including the file when it actually exists fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzer sometimes returns a hover result with language being "text", but there's no syntax/text.vim, so this would fail with:
Only including the file when it actually exists fixes this.
(Note that I had to substitute javascript for typescript in
test/test_hover_parsing.vaderbecause there's nosyntax/typescript.vimin vim 8.0 and neovim 0.2.)There are some, yeah.